Skip to content

fix(core): fix formOptions type inferance #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 14, 2025
Merged

fix(core): fix formOptions type inferance #1687

merged 6 commits into from
Aug 14, 2025
+305 −31

Conversation

harry-whorlow
Copy link
Contributor

Relates to #1613, this pr introduces more tests to form options, as well as fixes the typing error.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 11, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 71c7e62

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 36s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 19s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-13 15:46:19 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 11, 2025 •
edited
Loading

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1687

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1687

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1687

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1687

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1687

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1687

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1687

commit: 71c7e62

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@9e092e2). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1687   +/-   ##
=======================================
  Coverage        ?   90.52%           
=======================================
  Files           ?       37           
  Lines           ?     1688           
  Branches        ?      421           
=======================================
  Hits            ?     1528           
  Misses          ?      143           
  Partials        ?       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harry-whorlow harry-whorlow marked this pull request as ready for review August 12, 2025 09:45
@harry-whorlow harry-whorlow mentioned this pull request Aug 12, 2025
Open
@harry-whorlow harry-whorlow merged commit b8476c1 into TanStack:main Aug 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Balastrong Balastrong Balastrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harry-whorlow @Balastrong @LeCarbonator